Tests for ./scripts/release-post.js#193
Merged
fhemberger merged 1 commit intonodejs:masterfrom Sep 25, 2015
Merged
Conversation
Created a test suite for the ever growing release blog post script, with a mix of: * tape for running tests * nock for overriding network responses * proxyquire for mocking `require()`-d modules * sinon for spying on calls made on fake callbacks
Contributor
|
Haven't worked with tape before (usually using hapi's lab, which includes code coverage as well), but I'm fine with whatever works. And as you are the first one who wrote tests at all, I'm grateful for having them. ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a test suite for the ever growing release blog post script, with a mix of:
require()-d modulesThis doesnt make the script 100% covered with tests, although it's a start and ensures most of the current behavior still works when doing changes in the future.
Any thoughts about chosen frameworks or tests?